Align Events between Bulletin and SDK #10445
Conversation
raymondkfcheung
added
the
T1-FRAME
|
/cmd prdoc --audience runtime_dev --bump patch |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
| log = { workspace = true } | ||
| pallet-balances = { workspace = true } | ||
| scale-info = { features = ["derive"], workspace = true } | ||
| serde = { optional = true, workspace = true, default-features = true } | ||
| sp-inherents = { workspace = true } | ||
| sp-io = { workspace = true } | ||
| sp-runtime = { workspace = true } | ||
| sp-transaction-storage-proof = { workspace = true } | ||
| tracing = { workspace = true } |
There was a problem hiding this comment.
Why do you remove log and add tracing here? I don't see tracing added anywhere else except for this file
There was a problem hiding this comment.
Make it consistent with the Bulletin chain repo. If you prefer, I can remove tracing, and then add it back later when it's needed.
There was a problem hiding this comment.
Cool, I don't mind having this change as part of this PR but, please, make sure to mention this change in the PR description or the prdoc file (or both 🙃)
There was a problem hiding this comment.
because when I see something like this - first thing that comes to mind - is that it was an unintentional change
|
/cmd bench --pallet pallet_transaction_storage |
|
Command "bench --pallet pallet_transaction_storage" has started 🚀 See logs here |
|
Command "bench --pallet pallet_transaction_storage" has failed ❌! See logs here |
@raymondkfcheung this won't work, you need to use |
raymondkfcheung
changed the title
hash field to Event::Stored and Event::Renewed
raymondkfcheung
changed the title
raymondkfcheung
changed the title
bkontur
added
the
A4-backport-stable2512
* Align events between Bulletin and SDK * Extends `Stored` and `Renewed` events with a `hash: ContentHash` field. * Replaces `log` with `tracing` to match Bulletin’s logging approach. Addresses paritytech/polkadot-bulletin-chain#86, paritytech/polkadot-bulletin-chain#123 Relates to - [x] paritytech/polkadot-bulletin-chain#124 - [x] paritytech/polkadot-bulletin-chain#127 - [x] paritytech/polkadot-bulletin-chain#129 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit f757162)
|
Successfully created backport PR for |
StoredandRenewedevents with ahash: ContentHashfield.logwithtracingto match Bulletin’s logging approach.Addresses paritytech/polkadot-bulletin-chain#86, paritytech/polkadot-bulletin-chain#123
Relates to
hashfield toEvent::StoredandEvent::Renewedpolkadot-bulletin-chain#124content_hashpolkadot-bulletin-chain#129