-
Notifications
You must be signed in to change notification settings - Fork 4
Added justfile #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added justfile #111
Conversation
|
|
||
| # Test the complete workflow (builds, starts services, runs example, shuts down services) | ||
| # Parameters: api=[papi|pjs] - choose between Polkadot API (papi) or Polkadot JS (pjs) | ||
| authorize-and-store api="papi": build npm-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we want to use this command in README we'd have to refactor that README significantly
| kill $IPFS_PID $ZOMBIENET_PID $RECONNECT_PID 2>/dev/null || true | ||
|
|
||
|
|
||
| exit $EXAMPLE_EXIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jfyi: newline is not needed here. I cross-checked with ahm-dryrun repo
raymondkfcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check to use $(ls zombienet-*-*) instead of hardcoded.
|
good catch, I had this comment in my previous PR |
fixed |
| @@ -0,0 +1,112 @@ | |||
| # Polkadot Bulletin Chain - Just Commands | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@x3c41a I am missing here some README.md update how to run/use this justfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought the description would be enough.
Generally it's is as simple as just <command>, e.g. just authorize-and-store.
let me make a PR really quick...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just authorize-and-store pjs- to run e2eauthorize_and_storetest with PJS,just authorize-and-store papiorjust authorize-and-store- to test with PAPIRelates to #108