Skip to content

Add Talisman wallet #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Talisman wallet #71

wants to merge 7 commits into from

Conversation

smiasojed
Copy link
Contributor

@smiasojed smiasojed commented May 7, 2025

Add Talisman wallet to Remix tutorial

smiasojed added 2 commits May 7, 2025 23:40

Verified

This commit was signed with the committer’s verified signature.
smiasojed Sebastian Miasojed

Verified

This commit was signed with the committer’s verified signature.
smiasojed Sebastian Miasojed
@smiasojed smiasojed marked this pull request as ready for review May 8, 2025 12:46
@athei
Copy link
Member

athei commented May 9, 2025

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

@smiasojed
Copy link
Contributor Author

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

Yes, I know. Metamask still works for small contracts, so I left it there. Do you want to switch to Talisman, or should we include descriptions for both Metamask and Talisman?

@athei
Copy link
Member

athei commented May 9, 2025

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

Yes, I know. Metamask still works for small contracts, so I left it there. Do you want to switch to Talisman, or should we include descriptions for both Metamask and Talisman?

Just replace everything with Talisman. Otherwise people will run into this issue with sizes. But add a hint that Metamask still works for calling contracts (users are not affected). But developers should use Talisman.

smiasojed and others added 4 commits May 12, 2025 13:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: PG Herveou <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: PG Herveou <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: PG Herveou <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
smiasojed Sebastian Miasojed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants