Skip to content

Conversation

@smiasojed
Copy link
Contributor

@smiasojed smiasojed commented May 7, 2025

Add Talisman wallet to Remix tutorial

@smiasojed smiasojed marked this pull request as ready for review May 8, 2025 12:46
@athei
Copy link
Member

athei commented May 9, 2025

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

@smiasojed
Copy link
Contributor Author

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

Yes, I know. Metamask still works for small contracts, so I left it there. Do you want to switch to Talisman, or should we include descriptions for both Metamask and Talisman?

@athei
Copy link
Member

athei commented May 9, 2025

I think there is still some reference to MetaMask left in the "connect to local node" chapter?

Yes, I know. Metamask still works for small contracts, so I left it there. Do you want to switch to Talisman, or should we include descriptions for both Metamask and Talisman?

Just replace everything with Talisman. Otherwise people will run into this issue with sizes. But add a hint that Metamask still works for calling contracts (users are not affected). But developers should use Talisman.

@smiasojed smiasojed merged commit 030c328 into master May 19, 2025
5 checks passed
@smiasojed smiasojed deleted the sm/talisman branch May 19, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants