Merge pull request #458 from parea-ai/fix-target-dumping

fix: make using target safe

parea/parea_logger.py

@@ -61,6 +61,8 @@ def default_log(self, data: TraceLog) -> None:
         if self._redis_cache:
             self.write_log(data)
         if self._client:
+            if data.target:
+                data.target = json_dumps(data.target)
             self.record_log(data)
 
     def record_vendor_log(self, data: dict[str, Any], vendor: TraceIntegrations) -> None:

parea/utils/trace_utils.py

@@ -248,27 +248,14 @@ def wrapper(*args, **kwargs):
 
 def call_eval_funcs_then_log(trace_id: str, eval_funcs: list[Callable] = None):
     data = trace_data.get()[trace_id]
-    data_evals = data
-    if data.target is not None and not isinstance(data.target, str):
-        data_evals = deepcopy(data)
-        target = data.target
-        try:
-            target = json.dumps(target)
-        except TypeError:
-            try:
-                target = json_dumps(target)
-            except TypeError:
-                # if we can't serialize the value, just convert it to a string
-                target = str(target)
-        data.target = target
     parea_logger.default_log(data=data)
 
     if eval_funcs and data.status == "success" and random() <= data.apply_eval_frac:
         thread_ids_running_evals.get().append(trace_id)
         scores = []
         for func in eval_funcs:
             try:
-                scores.append(NamedEvaluationScore(name=func.__name__, score=func(data_evals)))
+                scores.append(NamedEvaluationScore(name=func.__name__, score=func(data)))
             except Exception as e:
                 logger.exception(f"Error occurred calling evaluation function '{func.__name__}', {e}", exc_info=e)
         parea_logger.update_log(data=UpdateLog(trace_id=trace_id, field_name_to_value_map={"scores": scores}))

pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "poetry.core.masonry.api"
 [tool.poetry]
 name = "parea-ai"
 packages = [{ include = "parea" }]
-version = "0.2.70"
+version = "0.2.71"
 description = "Parea python sdk"
 readme = "README.md"
 authors = ["joel-parea-ai <[email protected]>"]