Add email api endpoints #6
Conversation
Request JSON responses and update tests to reflect the JSON API Fix the format argument to be json and set the output param to simple
|
Awesome. |
|
Note that this pull request includes all the changes for this other pull request |
|
Would love to see this endpoint exposed. What needs to be done to merge? |
|
Sorry I let this hang out there so long. I'd like to get #14 merged and then revisit this as it's a very nice and much needed clean-up/refactor. |
|
FYI, I did eventually add Email API support to my personal branch (commit). It's changeset is a little more manageable than this one's, but I didn't want to create a competing PR |
|
Hey guys, sorry for letting this languish on my end too. I've started a new job since originally submitting this and haven't had the time to devote. I won't be offended if you go with the smaller changeset from @dcunning :-) If you think it's worth salvaging any parts of this though let me know and I can see extracting parts of it. |
|
I'd love to get email support and JSON added, but those feel like two different efforts to me. @dcunning could you create PR for email based on the current version (XML) and then we can sweep back through one personAccounts + email are added with the JSON-ification? |
|
Please rebase off the latest in master with support for prospectAccounts and we can get this merged! |
|
I was mistaken earlier saying I didn't create a pull request for my email endpoints. I did and it has already been accepted. Didn't realize it until I tried to create another. |
|
Nice, thanks Dan. Then the only task outstanding would be converting the API to use JSON instead of XML, which seems like a bit of a yak shave, but I would be willing to accept a PR as long as it's extremely well tested. |
This builds on my previous pull request and adds in support for the new email API endpoints:
http://developer.pardot.com/kb/api-version-3/reading-emails
http://developer.pardot.com/kb/api-version-3/sending-one-to-one-emails
http://developer.pardot.com/kb/api-version-3/sending-list-emails