Update the socket path to new location #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
commented
Sep 24, 2020
| @@ -18,7 +18,7 @@ use std::io::{Error, ErrorKind}; | |||
| #[cfg(not(feature = "no-fs-permission-check"))] | |||
| use std::os::unix::fs::MetadataExt; | |||
|
|
|||
| const DEFAULT_SOCKET_PATH: &str = "/tmp/parsec/parsec.sock"; | |||
| const DEFAULT_SOCKET_PATH: &str = "/run/parsec/parsec.sock"; | |||
There was a problem hiding this comment.
There is already a way to modify the path of the socket at runtime, so for test I think we can change this path to /tmp/parsec.sock in the e2e_tests folder directly.
There was a problem hiding this comment.
There is? Wow, I had some good foresight there
Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
new-socket-path
branch
from
daadfcf to
e4a01fa
Compare
ionut-arm
approved these changes
Sep 28, 2020
| @@ -18,7 +18,7 @@ use std::io::{Error, ErrorKind}; | |||
| #[cfg(not(feature = "no-fs-permission-check"))] | |||
| use std::os::unix::fs::MetadataExt; | |||
|
|
|||
| const DEFAULT_SOCKET_PATH: &str = "/tmp/parsec/parsec.sock"; | |||
| const DEFAULT_SOCKET_PATH: &str = "/run/parsec/parsec.sock"; | |||
There was a problem hiding this comment.
There is? Wow, I had some good foresight there
|
I will wait for consensus on the three PRs before I start merging any of them 🚀 Just in case some changes is still needed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue for details.