Skip to content

Conversation

@shamoon
Copy link
Member

@shamoon shamoon commented Oct 4, 2025

Proposed change

See #10998 (a FR IMHO)

Obviously IGNORABLE_FILES contains some dir patterns (to leave the consumer usage unchanged) but will still work for our purposes here.

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner October 4, 2025 14:46
@shamoon shamoon enabled auto-merge (squash) October 4, 2025 14:46
@github-actions github-actions bot added enhancement New feature or enhancement backend labels Oct 4, 2025
@shamoon shamoon added this to the v2.19.0 milestone Oct 4, 2025
@github-actions github-actions bot added the non-trivial Requires approval by several team members label Oct 4, 2025
@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (d609b38) to head (e98aae2).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10999   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files         524      524           
  Lines       23190    23191    +1     
  Branches     1757     1830   +73     
=======================================
+ Hits        22686    22687    +1     
  Misses        504      504           
Components Coverage Δ
backend 96.65% <100.00%> (+<0.01%) ⬆️
frontend 99.18% <ø> (ø)
Flag Coverage Δ
backend-python-3.10 96.65% <100.00%> (+<0.01%) ⬆️
backend-python-3.11 96.65% <100.00%> (+<0.01%) ⬆️
backend-python-3.12 96.65% <100.00%> (+<0.01%) ⬆️
frontend-node-20.x 99.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/documents/sanity_checker.py 100.00% <ø> (ø)
src/paperless/settings.py 94.44% <100.00%> (+0.01%) ⬆️

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2025

Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense

@shamoon shamoon merged commit 79b30fb into dev Oct 6, 2025
45 checks passed
@shamoon shamoon deleted the feature-sanity-ignore-files branch October 6, 2025 16:59
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backend enhancement New feature or enhancement non-trivial Requires approval by several team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants