Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod updates #23

Merged
merged 1 commit into from
Feb 20, 2024
Merged

mod updates #23

merged 1 commit into from
Feb 20, 2024

Conversation

stovak
Copy link
Member

@stovak stovak commented Feb 20, 2024

  • The httprouter version is invalid and is causing issues in Platform-go-sdk. Also, there's a newer version of uuid.

  • Locking to go 1.21

  • Pulling the executor from public go build image

@stovak stovak requested a review from a team as a code owner February 20, 2024 19:18
.gitignore Outdated Show resolved Hide resolved
@djschaap
Copy link
Member

You might want to mention in the PR title/description that you're also 1) locking the build to Go 1.21 (before, it was "latest") and 2) pulling that executor from Artifact Registry (instead of Quay.io).

This is a PUBLIC repo - is it appropriate that CI/CD is relying on internal images? Are you sure we need the sig-go-project context for this build?

If you were to use a public Go image, such as docker.io/library/golang:1.21, you may be able to remove the need for all internal/static secrets.

@stovak
Copy link
Member Author

stovak commented Feb 20, 2024

You might want to mention in the PR title/description that you're also 1) locking the build to Go 1.21 (before, it was "latest") and 2) pulling that executor from Artifact Registry (instead of Quay.io).

This is a PUBLIC repo - is it appropriate that CI/CD is relying on internal images? Are you sure we need the sig-go-project context for this build?

If you were to use a public Go image, such as docker.io/library/golang:1.21, you may be able to remove the need for all internal/static secrets.

Done.

@stovak stovak requested a review from kporras07 February 20, 2024 21:14
.circleci/config.yml Outdated Show resolved Hide resolved
@djschaap
Copy link
Member

I'd suggest squashing ("fixup"ing) these commits into one before merging to keep the git history clean/readable.

build with latest golang

quay must die

adding circle context for gcp-ar

adding context

removing .gitignore file

removing private image

linting

removing blank lines at the end
Copy link
Member

@djschaap djschaap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@stovak stovak merged commit 34714f6 into master Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants