-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod updates #23
mod updates #23
Conversation
You might want to mention in the PR title/description that you're also 1) locking the build to Go 1.21 (before, it was "latest") and 2) pulling that executor from Artifact Registry (instead of Quay.io). This is a PUBLIC repo - is it appropriate that CI/CD is relying on internal images? Are you sure we need the sig-go-project context for this build? If you were to use a public Go image, such as |
Done. |
I'd suggest squashing ("fixup"ing) these commits into one before merging to keep the git history clean/readable. |
build with latest golang quay must die adding circle context for gcp-ar adding context removing .gitignore file removing private image linting removing blank lines at the end
e76da55
to
8dc98b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The httprouter version is invalid and is causing issues in Platform-go-sdk. Also, there's a newer version of uuid.
Locking to go 1.21
Pulling the executor from public go build image