fix signin & signup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for arcinvoice pending review. 🔨 Explore the source changes: 4457249 |
|
@tobyleye sounds great! |
iamfeek
reviewed
Mar 22, 2022
|
|
||
| const googleError = (error) => { | ||
| console.log(error); | ||
| console.log("Google Sign In was unseccassful. Try again later"); |
There was a problem hiding this comment.
Suggested change
| console.log("Google Sign In was unseccassful. Try again later"); | |
| console.log("Google Sign In was unsuccessful. Try again later."); |
iamfeek
reviewed
Mar 22, 2022
| const [isLoading, setIsLoading] = useState(false); | ||
|
|
||
| const googleSuccess = async (res) => { | ||
| console.log(res); |
There was a problem hiding this comment.
It is best if we dont leave console.logs in our code.
iamfeek
suggested changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for not giving context as to why this pr was raised.
The authentication pages i.e signup & login are not user friendly atm. The
Get Startedbutton on the header takes user to a /login route and renders a login form. I understand there's a logic that conditionally renders the login/signup form based on a local boolean state but it isn't tied to theGet Startedbutton.So this pr was raised in order to separate these two pages and properly link them
I look forward to your review & feedback. Thank you.
@panshak