Some cleanups #31
Open
Some cleanups #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -477,7 +477,6 @@ Copyright (c) 2014 Rafał Lindemann. http://panrafal.github.com/depthy | |||
| if (depth.useAlpha) { | |||
| // move inverted alpha to rgb, set alpha to 1 | |||
| depthTextureSprite.filters.push(invertedAlphaToRGBFilter); | |||
| depthTextureSprite.filters = depthTextureSprite.filters; | |||
There was a problem hiding this comment.
AFAIR it was set on purpose, are you sure it works correctly now?
There was a problem hiding this comment.
Yep, seems to work just fine. :)
On Tue, Nov 24, 2015 at 3:53 AM, Rafał Lindemann [email protected]
wrote:
In app/scripts/classes/DepthyViewer.js
#31 (comment):@@ -477,7 +477,6 @@ Copyright (c) 2014 Rafał Lindemann. http://panrafal.github.com/depthy
if (depth.useAlpha) {
// move inverted alpha to rgb, set alpha to 1
depthTextureSprite.filters.push(invertedAlphaToRGBFilter);
depthTextureSprite.filters = depthTextureSprite.filters;AFAIR it was set on purpose, are you sure it works correctly now?
—
Reply to this email directly or view it on GitHub
https://github.com/panrafal/depthy/pull/31/files#r45725779.
Mikhail Yurasov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.