Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibration-services package #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

daviddoji
Copy link
Collaborator

My first attempt on creation a spack package.

@RobertRosca
Copy link
Collaborator

I'll pull some changes in form master and add some comments after

@RobertRosca
Copy link
Collaborator

Rebased on master to get some changes to how the CI runs in.

I added py-calibration-services to the .github/spack-config/spack.yaml file, then ran generate-workflows.py to create the test for this package.

Now only the CI for the specific package being modified will run, if the tests pass then we can merge it but I'm not 100% sure that all the dependencies exist for this.

Comment on lines +45 to +46
depends_on('[email protected]:')
depends_on('[email protected]:')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These to dependencies are missing, I can work on adding them in when I have time though.

depends_on('[email protected]:')
depends_on('[email protected]:')
depends_on('py-iminuit')
depends_on('[email protected]:')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The py-pyfai package provided in this repository isn't finished yet so this won't work until I get around to figuring out the setup steps for that.


# FIXME: Add a proper url for your package's homepage here.
homepage = "https://git.xfel.eu/gitlab/dataAnalysis/calibration-services"
url = "https://git.xfel.eu/gitlab/dataAnalysis/calibration-services/-/archive/dev/calibration-services-dev.tar.gz"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling in code from our private gitlab repository won't work unless the repo is set to public (which this one isn't).

There are ways around this which I can set up, in the end we'll probably just have two spack repositories: one on GitHub which has all our open source software on it, and one on GitLab with everything that isn't on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants