Fix PeriodIndex.is_full for duplicate periods #64063
Open
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@_maintainers this PR assumes is_full should also be false when there are duplicates, since that breaks the “range-like” idea (or not I think maybe the docstring could clarify that being “full” does not require values to be unique). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodIndex.is_full currently returns True for monotonic indexes that contain duplicate period.
for example, a monthly index like ["2023-01", "2023-02", "2023-02", "2023-03"] is monotonic but not rangelike, so is_full should be False per the docstring.
the existing check allows zero-differences between consective values; this change requires a strict step of one period instead.
the fix is small and directly matches the documented behavior, so I put up the pr directly.