[WIP] Create simdjson extension #63233
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: stop ignoring c and cpp files They are generated in the build directory. fix: statically link simdjson
Alvaro-Kothe
force-pushed
the
refactor/simdjson
branch
from
8de9528 to
1fac6f9
Compare
divya1974
reviewed
Dec 11, 2025
Contributor
divya1974
left a comment
divya1974
left a comment
There was a problem hiding this comment.
- In pandas/_libs/src/parser/json.cpp : Missing explicit GIL handling and no try/catch around C++ exceptions — risk of C++ exceptions escaping to Python and leaking resources.
- _json.py : No clear fallback/warning path when the native simdjson extension fails to import/compile; users may get import errors instead of a documented fallback.
- pyproject.toml : You added native code and new subprojects but didn’t update build/test instructions or include meson steps in CI/docs; packaging may fail for users installing from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an idea of using simdjson in pandas, partially following #58278.
I also explored
pysimdjson, which would be viable and do the exact same thing that this PR does. Although, it only decodes, while creating an extension permits to create an encoder on top of simdjson.From the current PR, compared to ultrajson, it shows no performance increase and memory consumption remained similar, while with pysimdjson seems to increase the memory consumption slightly.