DOC: add whatsnew note about __module__ changes for the public API #62784
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested review from
Dr-Irv and
rhshadrach
and removed request for
rhshadrach
15 tasks
Dr-Irv
requested changes
Oct 22, 2025
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| The ``__module__`` attribute on functions and classes in the public API has been | ||
| updated to refer to the preferred public module from which to access the object, |
There was a problem hiding this comment.
Suggested change
| updated to refer to the preferred public module from which to access the object, | |
| updated to refer to the preferred public module from which to access the member of the API, |
I don't think using "object" here makes sense in referring to "function"
There was a problem hiding this comment.
From the "everything in Python in an object", I think this makes sense.
There was a problem hiding this comment.
Hadn't heard that statement before. But it makes sense. I'll leave it up to Joris if he wants to change it.
There was a problem hiding this comment.
Also good with object. This statement also applies to class instances (e.g. pd.NA).
There was a problem hiding this comment.
Yeah, I wanted to avoid repeating "function or class".
Will leave it as is then
|
|
||
| The ``__module__`` attribute on functions and classes in the public API has been | ||
| updated to refer to the preferred public module from which to access the object, | ||
| rather than the module in which the object happens to be defined (:issue:`55178`). |
There was a problem hiding this comment.
Suggested change
| rather than the module in which the object happens to be defined (:issue:`55178`). | |
| rather than the module in which the member happens to be defined (:issue:`55178`). |
mroeschke
approved these changes
Oct 22, 2025
Dr-Irv
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To finish the work of #55178, adding a whatsnew note about this