BUG: Require sample weights to sum to less than 1 when replace = True #61582
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microslaw
force-pushed
the
add-df-sample-weight-constraints
branch
2 times, most recently
from
1281002 to
1d1f742
Compare
rhshadrach
requested changes
Jun 6, 2025
pandas/core/sample.py
Outdated
Comment on lines
153
to
159
| if weight_sum > 1 and replace: | ||
| raise ValueError( | ||
| "Invalid weights: If `replace`=True weights must sum to less than 1" | ||
| ) |
There was a problem hiding this comment.
This is not the correct condition. See the formula in the OP of the linked issue.
yuanx749
reviewed
Jun 6, 2025
pandas/core/generic.py
Outdated
Comment on lines
5818
to
5819
| When replace = True will not allow weights that add up to less | ||
| than 1, to avoid biased results. |
There was a problem hiding this comment.
Suggested change
| When replace = True will not allow weights that add up to less | |
| than 1, to avoid biased results. | |
| When replace = False will not allow ``(n * max(weights) / sum(weights)) > 1``, | |
| to avoid biased results. |
microslaw
force-pushed
the
add-df-sample-weight-constraints
branch
2 times, most recently
from
46f7059 to
2bc3618
Compare
microslaw
force-pushed
the
add-df-sample-weight-constraints
branch
from
2bc3618 to
e5f9a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.