Managed unit_list.json #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a PA Server Mod Manager that enables new game lobby and live game scenes for server mods like Display Rank and Unit Selector without the hackery of shadowing js files. Multiple server mods can now customise the new game lobby and live game user interface scenes for all players in a game. The PA Server Mod Manager is only mounted when other server mods are enabled.
Final implementation that creates a shadow of ui_mod_list.js as ui_mod_list_for_server.js that is loaded in the server version of ui_mod_list.js to merge server mod scenes into local client mod scenes
PAMM Support for Server Mods in New Game Lobby and Live Game Scenes
Fixed typo and add more exception handling for edge cases
…ld legacy code constraints
- adds a check for server mod scenes to determine if the PA Server Mod Manager should be enabled - additional logging and error checking
- adds a check for server mod scenes to determine if the PA Server Mod Manager should be enabled - additional logging and error checking
- adds a check for server mod scenes to determine if the PA Server Mod Manager should be enabled - additional logging and error checking
Enable PA Server Mod Manager only when scenes are used
…froze version 0.19.5
…can use the appropriate pool
Condition would persist, leaving the builtin mod disabled when enabling individual mods.
Disable-all should not mark pamm-server disabled
Member
|
Hi, |
Contributor
Author
|
Ah, okay. I thought there might be something more involved with the installer packages. Perhaps I'll ask on the forums for some testers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described https://forums.uberent.com/threads/proposal-pamm-managed-unit_list-json.70960/
Recognizes extensions to modinfo.json, as well as inferring changes from unit_list.json in existing server mods. Changes applied using remove-then-add as described in forum topic.
As a result of refactoring, the pamm client mod may also be disabled if it is not required.