Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verifyTX on message attestation #410

Merged

Conversation

maharifu
Copy link
Contributor

Related Github tickets

Background

See palomachain/paloma#1218

  • Add valset ID we get from compass to the public access data of messages

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

@maharifu maharifu changed the title Lcarvalho/1857 fix message attestation fix: verifyTX on message attestation Jul 10, 2024
byte-bandit
byte-bandit previously approved these changes Jul 10, 2024
Copy link
Collaborator

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maharifu
Copy link
Contributor Author

Thanks for reviewing, @byte-bandit. It's probably best to leave this open for now until we release paloma 1.15.3 tomorrow. I'll update the go.mod and merge then.

@maharifu maharifu force-pushed the lcarvalho/1857-fix-message-attestation branch from c36aeaa to 4250a88 Compare July 12, 2024 11:04
@maharifu maharifu enabled auto-merge (squash) July 12, 2024 11:15
@maharifu maharifu merged commit e67b2e4 into palomachain:master Jul 12, 2024
2 checks passed
@taariq taariq deleted the lcarvalho/1857-fix-message-attestation branch July 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants