Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parallel processing #182

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

ToasterTheBrave
Copy link
Contributor

Related Github tickets

Background

The first in a list of improvements for Pigeon speed. Pigeons are simply too slow and we are speeding them up.

Included in this PR:

  • Separated and tested the code for signing, relaying, and attesting
  • Split signing, relaying, and attesting into different threads to run in parallel
  • Set the groundwork for running these on different intervals
  • Fixed a thread leak in build_processors. This thread leak is what was causing the servers to run out of inodes. With parallel processing, this got way worse and had to be addressed.

Testing completed

  • wrote tests
  • tested running on a local private testnet

Tyler Ruppert added 2 commits June 12, 2023 09:59
* Separated and tested the code for signing, relaying, and attesting
* Split signing, relaying, and attesting into different threads to run
  in parallel
* Set the groundwork for running these on different intervals
* Fixed a thread leak in build_processors.  This thread leak is what was
  causing the servers to run out of inodes.  With parallel processing,
this got way worse and had to be addressed.
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A big improvement.

@taariq taariq merged commit a057c75 into palomachain:master Jun 12, 2023
1 check passed
@taariq taariq deleted the parallel-processing branch June 12, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants