Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debugger.js DOM Text Interpreted As HTML #3015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shivam7-1
Copy link

@Shivam7-1 Shivam7-1 commented Dec 27, 2024

Description:
By using textContent it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML

@ThiefMaster
Copy link
Member

ThiefMaster commented Dec 27, 2024

Is this PR AI-generated? Please explain how a hardcoded string [console ready] can contain XSS... :)

FWIW I tend to agree that textContent makes more sense than innerHTML here, but there's no real advantage in this particular case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants