Provide timing info to ProfilerMiddleware filename_format #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next version will be 3.0, not 2.4, can you fix that and squash all your commits. |
davidism
reviewed
Sep 5, 2023
This provides the `elapsed` and `time` values to the `ProfileMiddleware(filename_format=...)` function. Prior to this change, one could not replicate the format string format, much less modify how it would render the timestamp or elapsed time values. These new values can be found under the `werkzeug.profiler` key in the WSGI environ dict passed into the `filename_format()` function. Addresses pallets#2775
joshwilson-dbx
force-pushed
the
pass-timing-info-to-profiler-filename-format
branch
from
7c0d1e9
to
c7087f2
Compare
joshwilson-dbx
changed the title
joshwilson-dbx
changed the title
Should be good now. Are there plans to do a 2.3.8 release? It should now be safe to include in a minor or bugfix release now that these changes are backwards compatible. |
joshwilson-dbx
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the
elapsedandtimevalues to theProfileMiddleware(filename_format=...)function. Prior to this change,one could not replicate the format string format, much less modify how
it would render the timestamp or elapsed time values.
These new values can be found under the
werkzeug.profilerkey in theWSGI environ dict passed into the
filename_format()function.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.