Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for sunos5 in get_machine_id() #2773

Closed
wants to merge 1 commit into from
Closed

Conversation

mtelka
Copy link

@mtelka mtelka commented Aug 21, 2023

.. to get tests passed on illumos.

@ThiefMaster
Copy link
Member

Is this an operating system still used in the wild nowadays? seems a bit esoteric, so not sure if we want explicit code for it, especially in a pure development util

@mtelka
Copy link
Author

mtelka commented Aug 21, 2023

Is this an operating system still used in the wild nowadays? seems a bit esoteric, so not sure if we want explicit code for it, especially in a pure development util

Of course, it is. An illumos distro: https://www.openindiana.org/

@mtelka
Copy link
Author

mtelka commented Aug 21, 2023

And here is werkzeug packaged for OpenIndiana.

@davidism
Copy link
Member

Thanks, but I don't plan to merge this. It implies a level of support we can't provide. The debugger will still work without this (and note that the dev server and debugger should never be accessible externally anyway, so being able to generate a more random pin is the last thing to worry about).

@davidism davidism closed this Aug 21, 2023
@mtelka
Copy link
Author

mtelka commented Aug 21, 2023

Okay, np. Your project, your rules. :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants