Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip leading/trailing whitespace from header values before checking #2764

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Aug 12, 2023

Replaces #2738 (targets correct branch). Fixes #2734

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

bentasker and others added 2 commits August 12, 2023 22:08
This in turn ensures that the whitespace (leading or trailing) is
stripped and the correct length is returned.
This is required for the `| None` syntax to be understood in older
Python versions.
@pgjones pgjones merged commit 3712c7b into pallets:2.3.x Aug 12, 2023
9 checks passed
@pgjones pgjones deleted the plain_strip branch August 12, 2023 21:19
@davidism davidism added this to the 2.3.7 milestone Aug 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants