Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Addition of Extra Newline in Binary File Uploads #2762

Closed
wants to merge 2 commits into from

Conversation

mohamedlmoutaouakil
Copy link

The change in this PR addresses the problem of wrong parsing of multipart request body. Specifically using a wrong index of the last newline in the file data in the MultipartDecoder.

The problem is passing index shifted data to last_newline method and using the index returned by this method directly on the original non-index-shifted data.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@raulpuric
Copy link

Can confirm this fixed my bugs. Thanks @mohamedlmoutaouakil

@pgjones
Copy link
Member

pgjones commented Aug 12, 2023

Closed in favor of #2763

@pgjones pgjones closed this Aug 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra Newline Added to Binary File Upload
3 participants