Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for initializing the i18n extension #2023

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 10, 2024

Refs the discussion at https://stackoverflow.com/a/78970088 to make it clearer what to do to hook up i18n.

@davidism
Copy link
Member

Remember to make docs changes to the latest .x branch rather than main, so that they show up in the current docs builds.

@akx akx changed the base branch from main to 3.1.x September 10, 2024 15:40
@akx akx marked this pull request as draft September 10, 2024 15:41
@akx akx marked this pull request as ready for review September 10, 2024 15:42
@akx
Copy link
Contributor Author

akx commented Sep 10, 2024

@davidism Retargeted & rebased on 3.1.x.

@davidism davidism added the docs label Sep 10, 2024
@davidism davidism merged commit af054f3 into pallets:3.1.x Sep 10, 2024
1 check passed
@myersjustinc
Copy link

Thank you for the edit, @akx, and thank you for the merge, @davidism! I'm the person who wrote the SO answer referenced above after trying to navigate this process without this explanation being present, so I really appreciate your help making things clearer for other users down the road.

@akx akx deleted the improve-i18n-docs branch September 10, 2024 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants