Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old version added and changed tags #1704 #1856

Closed
wants to merge 0 commits into from
Closed

Remove old version added and changed tags #1704 #1856

wants to merge 0 commits into from

Conversation

dawranliou
Copy link
Contributor

Removed the versionadded and versionchanged tags except for the one linked from external docs. Created issue pallets/pallets-sphinx-themes#60 to remove those tags from external docs.

@jeffwidman
Copy link
Contributor

LGTM, squash and I'll merge

@untitaker
Copy link
Contributor

Hang on, do we have any sort of consensus on what to do with those markers? Merging seems a bit too eager

@jeffwidman
Copy link
Contributor

No problem, I'll hold off.

Over in #1704 both myself and @davidism were on board with doing this and no one objected, so I assumed we were good to go.

@ThiefMaster
Copy link
Member

+1 for keeping them but making old ones look less important (or collapsing them). Removing them seems more like a good idea for a post-1.0 version once 1.0 is widespread and previous versions are considered obsolete and a bad idea to use

@dawranliou dawranliou closed this Jun 2, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants