Keep tracked files instead of refreshing list of untracked files #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatsmydoing
commented
Feb 29, 2024
| @@ -19,7 +19,7 @@ const untrackedFilename = "an-untracked-file.js"; | |||
|
|
|||
| const gitMocked: jest.MockedObjectDeep<typeof git> = jest.mocked(git); | |||
| gitMocked.getDiffFileList.mockReturnValue([filename]); | |||
| gitMocked.getUntrackedFileList.mockReturnValue([untrackedFilename]); | |||
| gitMocked.getTrackedFileList.mockReturnValue([filename, "file-with-dirty-index.js"]); | |||
There was a problem hiding this comment.
One of the tests also works with a file called file-with-dirty-index.js so we have to add it to the "tracked" list too.
| @@ -117,11 +110,12 @@ const getProcessors = ( | |||
| processorType: ProcessorType | |||
| ): Required<Linter.Processor> => { | |||
| const staged = processorType === "staged"; | |||
| const trackedFileSet = new Set(getTrackedFileList()); | |||
There was a problem hiding this comment.
I'm wrapping this in a Set for faster lookups.
Comment on lines
-34
to
-35
| const shouldRefresh = | ||
| !diffFileList.includes(filename) && !untrackedFileList.includes(filename); |
There was a problem hiding this comment.
This condition not only matches new files but actually all unchanged files, so instead of speeding things up this actually slows the entire lint process.
|
Yeah noticing this as well, it makes the initial lint take really long to run, even when there is nothing to lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27 introduced a massive performance regression with the recommended
diff/diffsetup. It effectively refreshes the list of untracked files for every unchanged file in the project.Instead of constantly refreshing the tracked file list, it's better to get the list of tracked files once and we can simply check that a file is not in the list.