Fine tuning Yeo Johnson (#31)

* add M1 CI, fix test on M1 * add YeoJohnson to precompile load * only do percy on ubuntu * version bump
palday · Aug 9, 2024 · d2b9b4a · d2b9b4a · palday · Aug 9, 2024
1 parent 6d29a05
commit d2b9b4a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,17 +21,19 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        version: [1.9, 1]
-        arch: [x64]
-        os: [ubuntu-latest]
+        version:
+            - '1.9'
+            - '1'
+        os:
+            - ubuntu-latest
+            - macos-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Julia Setup
         uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.version }}
-          arch: ${{ matrix.arch }}
       - uses: julia-actions/cache@v2
         with:
             cache-compiled: "true"
@@ -52,15 +54,15 @@ jobs:
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       - name: Setup Node for Percy
-        if: ${{ matrix.version == '1' }}
+        if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
         uses: actions/setup-node@v4
         with:
           node-version: '14'
       - name: Install Percy CI
-        if: ${{ matrix.version == '1' }}
+        if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
         run: npm install --save-dev @percy/cli
       - name: Percy Upload
-        if: ${{ matrix.version == '1' }}
+        if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
         run: |
           ls ./test/out/ # useful for debugging
           npx percy upload ./test/out

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "BoxCox"
 uuid = "1248164d-f7a6-4bdb-8e8d-8c4a187b3ce6"
 authors = ["Phillip Alday <[email protected]>"]
-version = "0.3.2"
+version = "0.3.3"
 
 [deps]
 DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"

diff --git a/src/BoxCox.jl b/src/BoxCox.jl
@@ -271,6 +271,8 @@ end
     @compile_workload begin
         fit(BoxCoxTransformation, y2)
         fit(BoxCoxTransformation, X, y2)
+        fit(YeoJohnsonTransformation, y)
+        fit(YeoJohnsonTransformation, X, y)
     end
 end
 

diff --git a/test/yeojohnson.jl b/test/yeojohnson.jl
@@ -158,7 +158,7 @@ end
     @test only(params(yt)) ≈ -1 atol = 0.1
     ci = confint(yt; fast=false)
     ref_ci = [-1.73449, -0.413651]
-    @test all(isapprox.(confint(yt; fast=true), ci; atol=0.01))
+    @test all(isapprox.(confint(yt; fast=true), ci; atol=0.05))
     @test all(isapprox.(ci, ref_ci; rtol=0.05))
 
     @testset "mixed models + makie integration" begin