PR: Add mypy plugin to core plugins #838
Conversation
Not 100% sure when this was introduced.
message contains now quotes in pyls 0.18.0
This provides slightly better context than just the single character at that point.
…word Highlight the word at the point Mypy flags it
Else we get all the errors for all the imported files on the current file.
Add '--follow-imports silent' to mypy invocation
mypy.api.run method should take List[str] of args. https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args https://github.com/python/mypy/blob/d40990f5b91b1f06918222d1041441b7ff63f79a/mypy/api.py#L71
Fix mypy==0.700 compatibility.
Seeing this with disallow_untyped_defs=True for example. Test on Windows before releasing?
Fix diagnostics start position
Added support for 'strict' setting
Moved the metadata to setup.cfg
Install and use future only if python2
|
@uschi2000, I'm also having troubles in this repo to merge pull requests. As you can see, the Appveyor integration is required to pass, but its status is not registered by Github. That's very strange because tests are passing just fine on the Appyevor servers: https://ci.appveyor.com/project/gatesn/python-language-server/builds/34455591 A possible solution for this would be to move to move testing to Github actions, as proposed by @goanpeca on PR #803. |
|
So it seems that the appveyor integration is done in terms of @gatesn 's user name. Since he is no longer in the Palantir Org this integration probably broke. |
|
@gatesn could you give me a hand in restoring/migrating/fixing the appveyor CI integration for this repo (and python-grpc)? Thanks very much! |
|
@steff456 What is the issue with using the plugin? It does its job just fine. Mypy daemon works best for project setups, while the plugin only runs the checker on a single file, missing a lot of type checks coming from imports, etc. as mentioned in the tomv564/pyls-mypy#24 |
|
@uschi2000 not sure what I need to do here? Can you remove appveyor from required checks? I had a look and it says AppVeyor permissions are inherited from GitHub perms. So if you're an admin here you should get admin there. |
|
@gatesn I personally have no idea what the appveyor integration does here and whether we need it or not ;) |
@uschi2000, thanks again for your help sorting out these issues. |
This PR migrates the pyls-mypy plugin, https://github.com/tomv564/pyls-mypy, to the core plugins of PyLS for us to maintain