Fix returned line numbers in McCabe plugin (#710)

palantir · Dec 4, 2019 · 48eedea · 48eedea
1 parent 30a995a
commit 48eedea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pyls/plugins/mccabe_lint.py b/pyls/plugins/mccabe_lint.py
@@ -30,8 +30,8 @@ def pyls_lint(config, document):
             diags.append({
                 'source': 'mccabe',
                 'range': {
-                    'start': {'line': graph.lineno, 'character': graph.column},
-                    'end': {'line': graph.lineno, 'character': len(document.lines[graph.lineno])},
+                    'start': {'line': graph.lineno - 1, 'character': graph.column},
+                    'end': {'line': graph.lineno - 1, 'character': len(document.lines[graph.lineno])},
                 },
                 'message': 'Cyclomatic complexity too high: %s (threshold %s)' % (graph.complexity(), threshold),
                 'severity': lsp.DiagnosticSeverity.Warning

diff --git a/test/plugins/test_mccabe_lint.py b/test/plugins/test_mccabe_lint.py
@@ -26,8 +26,8 @@ def test_mccabe(config):
         mod_import = [d for d in diags if d['message'] == msg][0]
 
         assert mod_import['severity'] == lsp.DiagnosticSeverity.Warning
-        assert mod_import['range']['start'] == {'line': 1, 'character': 0}
-        assert mod_import['range']['end'] == {'line': 1, 'character': 6}
+        assert mod_import['range']['start'] == {'line': 0, 'character': 0}
+        assert mod_import['range']['end'] == {'line': 0, 'character': 6}
     finally:
         config._settings = old_settings