Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowRoot setting to control if a cli is allowed to run as root #192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

montaguethomas
Copy link

@montaguethomas montaguethomas commented Sep 10, 2020

Adds new AllowRoot boolean setting to control if an implementation of cli App is allowed to run as UID 0 (root).
Defaults to false.


This change is Reviewable

Copy link
Contributor

@bmoylan bmoylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to false would be a breaking change for anything that wants to run as root and gets upgraded without knowledge of the breaking change. If we go this route it should maintain the same default behavior and opt-in to the stricter version.

That said, I'm not that keen on this solution to what was ultimately a bug in the infrastructure that should be fixed. The internal spawning daemon that caused the issue this is supposed to address already has this check in application code (added in April), so I'm not sure in what scenario this would help going forward.

@gregakinman
Copy link

@bmoylan I could see value in this as serving as a more general upstream implementation of the solution that was merged to the internal spawning daemon (since it uses this library so could just change its current implementation to using this feature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants