Custom attributes for <EditableText /> underlying textarea

[rallelind]

Fixes #6916

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

I added the ability to pass custom attributes to the underlying text area element. It was not clear to me if this should also be added for the underlying input and if so should that have a seperate prop? Or would we just use the same prop for the two.

Furthermore, this is the first time i try contributing to an open source project, would love feedback if any!

Screenshot

[palantirtech]

Thanks for your interest in palantir/blueprint, @rallelind! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[rallelind]

Thanks for your interest in palantir/blueprint, @rallelind! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

I did sign this, but it does not seem like the PR updated. Do i need to do anything?

[ggdouglas]

I think it's plausible that a consumer of this component might want to add custom attributes even when the component isn't multiline. Could we extend this prop to cover both cases? Something like:

Suggested change

	customTextareaAttributes?: {
	customInputAttributes?: {

return multiline ? (
    <textarea ref={this.refHandlers.input} {...props} {...customInputAttributes} />
) : (
    <input ref={this.refHandlers.input} type={type} {...props} {...customInputAttributes} />
);

We should also consider limiting the scope of attributes we can pass to just those of textarea and input elements:

type HTMLInputProps = React.InputHTMLAttributes<HTMLInputElement>;
type HTMLTextAreaProps = React.TextareaHTMLAttributes<HTMLTextAreaElement>;

{ customInputAttributes?: HTMLInputProps & HTMLTextAreaProps; }

[rallelind]

Makes perfect sense! I should have updated the tests and the prop to allow for this. Thanks for reviewing!

[ggdouglas]

Thanks for your interest in palantir/blueprint, @rallelind! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

I did sign this, but it does not seem like the PR updated. Do i need to do anything?

The PR is updated with the CLA check. You're all good!