-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from @import to @use #7074
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
Fixes #7031
This PR allows consumers to import Blueprint SCSS using
@use
and@forward
. Without this change, consumers must continue to use the old@import
rule, which has recently been deprecated.Checklist
Changes proposed in this pull request:
Converts all scss files from the now deprecated usage of
@import
to@use
and@forward
.The uses of
@import
still remaining are only those importing plain css, which SASS interprets as the native CSS import rule. These types of imports are only for the Blueprint apps (docs-app, landing-app, and table-dev-app) and follow the recommended guideline on how to import Blueprint's exported css.Documentation still recommends using the legacy
@import
rule, but I'll be happy to update it to recommend@use
or@forward
for any snippets illustrating scss importing.Reviewers should focus on:
Please note, the stylelint rule
at-rules-no-unknown
has been temporarily disabled until the custom palantir config begins allowing@use
and@forward
. You may want that repository updated first so this rule can be kept enabled.