Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate live reload without watchexec #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuatcasey
Copy link
Contributor

It appears that web servers will reload without watchexec

@joshuatcasey joshuatcasey requested a review from a team as a code owner July 29, 2022 18:37
@joshuatcasey joshuatcasey added the semver:patch A change requiring a patch version bump label Jul 29, 2022
@joshuatcasey joshuatcasey force-pushed the jtc/reload-without-watchexec branch from 77c4c06 to 11a5bc2 Compare July 29, 2022 18:56
@joshuatcasey joshuatcasey self-assigned this Aug 1, 2022
@ForestEckhardt
Copy link
Contributor

What is the purpose of adding these tests? I understand that it is something that can work but what are we trying to do?

@joshuatcasey
Copy link
Contributor Author

@ForestEckhardt This was really a technical exercise to see if it would work and it's saved off as a PR.

We had a discussion yesterday at standup about trying to capture all of the context around webservers (both here and in the PHP language) and reloading on a single issue and making a decision there.

@ForestEckhardt
Copy link
Contributor

I guess my question is what should I be doing about this PR then? Are we merging it as is or is there still a conversation happening?

@joshuatcasey
Copy link
Contributor Author

Let's leave it open for now. I'll say status/blocked on an overall decision.

@joshuatcasey joshuatcasey added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Aug 2, 2022
@joshuatcasey joshuatcasey force-pushed the jtc/reload-without-watchexec branch from 8767e5f to 7333057 Compare August 4, 2022 14:02
@joshuatcasey joshuatcasey force-pushed the jtc/reload-without-watchexec branch from 7333057 to ca81997 Compare September 16, 2022 02:05
@joshuatcasey
Copy link
Contributor Author

joshuatcasey commented Sep 16, 2022

I've proposed in paketo-buildpacks/php-start#37 that the PHP language family explicitly support live reload of served files without additional configuration such as BP_LIVE_RELOAD_ENABLED=true.

I propose that the web-servers adopt a similar approach:

  • Let nginx or httpd reload served files without requiring additional configuration since this happens anyways and is likely more responsive than reloading the process
  • Document that some configuration changes can result in reloading the nginx or httpd process, specifically file changes (not env var changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump status/blocked This issue has been triaged and resolving it is blocked on some other issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants