Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading service bindings from VCAP_SERVICES env var #566

Merged
merged 1 commit into from
May 2, 2024
Merged

Support reading service bindings from VCAP_SERVICES env var #566

merged 1 commit into from
May 2, 2024

Conversation

pbusko
Copy link
Contributor

@pbusko pbusko commented Apr 15, 2024

Summary

This PR adds VCAP_SERVICES environment variable as a source of service bindings

Use Cases

At the moment, both libcnb and libpak (through libcnb) support reading service bindings from VCAP_SERVICES environment variable. This PR will bring feature-parity between libpak and packit, as well as improve user experience for the upcoming CNB@CloudFoundry RFC: cloudfoundry/community#796

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pbusko pbusko requested a review from a team as a code owner April 15, 2024 14:54
@pbusko pbusko force-pushed the support-vcap-services branch 2 times, most recently from db4d7cd to 3b416f8 Compare April 24, 2024 08:05
@pbusko pbusko force-pushed the support-vcap-services branch from 3b416f8 to fb2f522 Compare April 30, 2024 20:56
@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label May 2, 2024
@sophiewigmore sophiewigmore merged commit 13393ec into paketo-buildpacks:v2 May 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@sophiewigmore sophiewigmore Awaiting requested review from sophiewigmore sophiewigmore is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbusko @ForestEckhardt @sophiewigmore