Testdata must not use NodeJs 16 anymore (#713)

paketo-buildpacks · Jun 20, 2024 · 39ee53a · 39ee53a
1 parent b839521
commit 39ee53a
Show file tree

Hide file tree

Showing 21 changed files with 22 additions and 22 deletions.
diff --git a/integration/caching_test.go b/integration/caching_test.go
@@ -223,7 +223,7 @@ func testCaching(t *testing.T, context spec.G, it spec.S) {
 					WithExtensions(
 						settings.Extensions.UbiNodejsExtension.Online,
 					).
-					WithEnv(map[string]string{"BP_NODE_VERSION": "~16"}).
+					WithEnv(map[string]string{"BP_NODE_VERSION": "~18"}).
 					WithBuildpacks(
 						settings.Buildpacks.NodeEngine.Online,
 						settings.Buildpacks.NPMInstall.Online,
@@ -255,7 +255,7 @@ func testCaching(t *testing.T, context spec.G, it spec.S) {
 					WithExtensions(
 						settings.Extensions.UbiNodejsExtension.Online,
 					).
-					WithEnv(map[string]string{"BP_NODE_VERSION": "~18"}).
+					WithEnv(map[string]string{"BP_NODE_VERSION": "~20"}).
 					WithBuildpacks(
 						settings.Buildpacks.NodeEngine.Online,
 						settings.Buildpacks.NPMInstall.Online,

diff --git a/integration/testdata/dev_dependencies_during_build/package.json b/integration/testdata/dev_dependencies_during_build/package.json
@@ -15,7 +15,7 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   },
   "devDependencies": {
     "chalk": "^5.0.0"

diff --git a/integration/testdata/empty_node_modules/package.json b/integration/testdata/empty_node_modules/package.json
diff --git a/integration/testdata/locked_app/package-lock.json b/integration/testdata/locked_app/package-lock.json
diff --git a/integration/testdata/locked_app/package.json b/integration/testdata/locked_app/package.json
@@ -15,6 +15,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/no_vendored_dependencies/package.json b/integration/testdata/no_vendored_dependencies/package.json
@@ -12,5 +12,5 @@
     "express": "~4.0.0",
     "chalk-cli": "~3.0.0"
   },
-  "engines" : { "node" : "~>16" }
+  "engines" : { "node" : "~>18" }
 }
diff --git a/integration/testdata/npm-cache/package-lock.json b/integration/testdata/npm-cache/package-lock.json
diff --git a/integration/testdata/npm-cache/package.json b/integration/testdata/npm-cache/package.json
@@ -17,6 +17,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/npmrc/package.json b/integration/testdata/npmrc/package.json
@@ -15,6 +15,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/pre_post_scripts_vendored/package-lock.json b/integration/testdata/pre_post_scripts_vendored/package-lock.json
diff --git a/integration/testdata/pre_post_scripts_vendored/package.json b/integration/testdata/pre_post_scripts_vendored/package.json
@@ -18,6 +18,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/project_path_app/server/package.json b/integration/testdata/project_path_app/server/package.json
@@ -15,6 +15,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/simple_app/package.json b/integration/testdata/simple_app/package.json
@@ -18,6 +18,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/unmet_dep/package.json b/integration/testdata/unmet_dep/package.json
@@ -13,7 +13,7 @@
     "logfmt": "^1.3.2"
   },
   "engines": {
-    "node": "~>16"
+    "node": "~>18"
   },
   "repository": {
     "type": "git",

diff --git a/integration/testdata/vendored/package-lock.json b/integration/testdata/vendored/package-lock.json
diff --git a/integration/testdata/vendored/package.json b/integration/testdata/vendored/package.json
@@ -17,6 +17,6 @@
     "url": ""
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/with_nvmrc/.nvmrc b/integration/testdata/with_nvmrc/.nvmrc
@@ -1 +1 @@
-18
+20
diff --git a/integration/testdata/with_nvmrc/package-lock.json b/integration/testdata/with_nvmrc/package-lock.json
diff --git a/integration/testdata/with_nvmrc/package.json b/integration/testdata/with_nvmrc/package.json
@@ -16,6 +16,6 @@
     "url": "http://github.com/cloudfoundry/nodejs-buildpack.git"
   },
   "engines": {
-    "node": "~16"
+    "node": "~18"
   }
 }
diff --git a/integration/testdata/with_nvmrc_and_no_engine/.nvmrc b/integration/testdata/with_nvmrc_and_no_engine/.nvmrc
@@ -1 +1 @@
-18
+20
diff --git a/integration/versioning_test.go b/integration/versioning_test.go
@@ -31,7 +31,7 @@ func testVersioning(t *testing.T, context spec.G, it spec.S) {
 	})
 
 	context("when using a nvmrc file", func() {
-		const nvmrcVersion = `18.\d+\.\d+`
+		const nvmrcVersion = `20.\d+\.\d+`
 
 		var (
 			image      occam.Image