Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding disclaimer for GO versioning support #955

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Adding disclaimer for GO versioning support #955

merged 2 commits into from
Sep 25, 2024

Conversation

pacostas
Copy link
Contributor

Summary

This PR Adds on the Readme file information about the maintenance of Go modules under the nodejs buildpacks.

Related issue:

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner September 20, 2024 08:23
@paketo-bot paketo-bot added the semver:patch A change requiring a patch version bump label Sep 20, 2024
@pacostas pacostas force-pushed the adding-go-disclaimer branch from 1a4ffea to 541976f Compare September 20, 2024 08:23
@pacostas
Copy link
Contributor Author

@mhdawson Feel free to suggest or rephrase it :)

mhdawson
mhdawson reviewed Sep 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pacostas
Copy link
Contributor Author

@mhdawson Thank you for the suggestion :)

mhdawson
mhdawson approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@c0d1ngm0nk3y does this sound good to you?

@pacostas pacostas force-pushed the adding-go-disclaimer branch from 16574be to fd5378e Compare September 25, 2024 08:21
@pacostas pacostas enabled auto-merge (squash) September 25, 2024 08:22
@pacostas pacostas merged commit 9137967 into paketo-buildpacks:main Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0d1ngm0nk3y c0d1ngm0nk3y c0d1ngm0nk3y approved these changes

@mhdawson mhdawson mhdawson approved these changes

@thitch97 thitch97 Awaiting requested review from thitch97 thitch97 is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@TisVictress TisVictress Awaiting requested review from TisVictress TisVictress is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacostas @mhdawson @c0d1ngm0nk3y @paketo-bot