Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop! #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions GemCity.rb

This file was deleted.

2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source 'https://rubygems.org'

gem 'rubocop', require: false
gem 'rspec'
gem 'rspec'
50 changes: 50 additions & 0 deletions gem_city.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# This class represents the town of GemCity
# This is a town riddled with crime but we can find out how happy the town is
class GemCity
def initialize
@people = { thieves: 5, Officers: 1 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@population = 50
end

def thieves(thieves_number = @people[:thieves])
@people[:thieves] = thieves_number
end

def officers
@people[:Officers]
end

attr_reader :population

def officers=(officers)
@people[:Officers] = officers
end

def happiness_of_town
# happiness is random... people don't know what they want!
happiness = 0
(1..@population).each do
happiness += (rand((100 - successful_crime_rate)..100))
end
happiness / 100
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method can be refactored. I also left it like this the first time ;)


def successful_crime_rate
if @people[:thieves] <= 0 || @people[:Officers] > @people[:thieves]
0
else
(1 - @people[:Officers].to_f / @people[:thieves].to_f) * 100
end
end

def compute_demo(count)
(count / @population.to_f * 100).round.to_s << '%'
end

def city_demographics
thieves = compute_demo(@people[:thieves])
officers = compute_demo(@people[:Officers])
civs = compute_demo(@population - @people[:thieves] - @people[:Officers])
{ thieves: thieves, officers: officers, civilians: civs }
end
end
40 changes: 20 additions & 20 deletions gem_city_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'rspec'
require_relative 'GemCity' # This line may need to be changed
require_relative 'gem_city' # This line may need to be changed

describe 'Gem City' do
let(:city) { GemCity.new }
Expand All @@ -16,7 +16,7 @@

it 'officers = thieves' do
city.thieves 1
city.setOfficers 1 # This line may need to be changed
city.officers = 1 # This line may need to be changed
expect(city.successful_crime_rate).to eq(0)
end

Expand All @@ -27,7 +27,7 @@

it 'officers > thieves' do
city.thieves 1
city.setOfficers 2 # This line may need to be changed
city.officers = 2 # This line may need to be changed
expect(city.successful_crime_rate).to eq(0)
end
end
Expand All @@ -43,21 +43,21 @@
end
end

# context 'city_demographics' do
# it 'initialize' do
# demographics = city.city_demographics
# expect(demographics[:thieves]).to eq('10%')
# expect(demographics[:officers]).to eq('2%')
# expect(demographics[:civilians]).to eq('88%')
# end

# it 'thieves = 10, officers = 25' do
# city.thieves = 10
# city.officers = 25
# demographics = city.city_demographics
# expect(demographics[:thieves]).to eq('20%')
# expect(demographics[:officers]).to eq('50%')
# expect(demographics[:civilians]).to eq('30%')
# end
# end
context 'city_demographics' do
it 'initialize' do
demographics = city.city_demographics
expect(demographics[:thieves]).to eq('10%')
expect(demographics[:officers]).to eq('2%')
expect(demographics[:civilians]).to eq('88%')
end

it 'thieves = 10, officers = 25' do
city.thieves 10
city.officers = 25
demographics = city.city_demographics
expect(demographics[:thieves]).to eq('20%')
expect(demographics[:officers]).to eq('50%')
expect(demographics[:civilians]).to eq('30%')
end
end
end