Dan Meehan solution #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
May 30, 2017
| def edit_beer | ||
| id = Print::get_input("\nEnter the id of the beer you want to EDIT:").to_i | ||
| b = @beerList.find_beer id | ||
| fail "No beer matching id #{id}" unless b |
There was a problem hiding this comment.
Both calls to find_beer fail when they don't get a result. Should find_beer be responsible for failing when it doesn't find one?
There was a problem hiding this comment.
You're right, find_beer should probably handle its own failure so there's a single point of failure instead of having to repeat this logic here and in edit_beer on line 41 of the model.
I guess the only reason to return nil and check outside find_beer would be if I wanted to do some other error handling instead of failing right away, which I didn't do anyway haha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo
@erikthiem