Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i have healthy relationships. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

i have healthy relationships. #51

wants to merge 1 commit into from

Conversation

LeslieKornes
Copy link

jaybobo
jaybobo reviewed May 15, 2018
View reviewed changes
associations.rb
def generate_migrations
ActiveRecord::Migration.create_table :hotels do |t|
#insert our columns here

t.integer "room_count"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm however i'd recommend using symbols here instead for column names.

see this post from late but legendary jim weirich:
https://groups.google.com/d/msg/columbusrb/cj-3jepBK1I/w2N5rYkzAqQJ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't seen that post before. Thanks for the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegee mikegee mikegee left review comments

@jaybobo jaybobo jaybobo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeslieKornes @mikegee @jaybobo @lkornescmm