Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed Gemfile.lock because gherkin version prevented bundle install… #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

removed Gemfile.lock because gherkin version prevented bundle install… #52

wants to merge 2 commits into from

Conversation

matthewlee07
Copy link

…. or add >= current version

@sjreich
Copy link

sjreich commented Nov 9, 2018

Hi Matt, let's move towards getting this change actually merged in.

  1. I can't really tell, but if you updated this by running bundle update, can you do so instead with bundle update cucumber? (The principal is to make small updates, rather than big ones.) If you already did the latter, then great.
  2. It looks like there are some things you changed that weren't essential or relevant. Can you drop those changes out? (The principal is to minimize the "churn" in the codebase.)
  3. Can you clean up the documentation around this PR - the name, the introductory comment, so that's obvious to everyone what was going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewlee07 @sjreich