Adding the endpoint to filter by month and week #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-20y76fa Add filters to Petitions |
nicocadq
requested changes
Apr 7, 2022
routes/api.php
Outdated
Comment on lines
37
to
38
| Route::get('/petitions/filter-month', [PetitionController::class, 'filterByMonth']); | ||
| Route::get('/petitions/filter-week', [PetitionController::class, 'filterByWeek']); |
There was a problem hiding this comment.
It should be all at the same endpoint, like:
/petitions?time="week"
or
/petitions?time="month"
nicocadq
requested changes
Apr 8, 2022
Comment on lines
36
to
+37
| Route::get('/petitions', [PetitionController::class, 'index']); | ||
| Route::get('/petitions/filter', [PetitionController::class, 'filter']); |
There was a problem hiding this comment.
This filter stuff should be done at the endpoint /petitions and the params should be time_period
nicocadq
requested changes
Apr 8, 2022
Comment on lines
26
to
27
| if ($time_period === "week") { | ||
| $byweek = Petition::whereBetween('created_at', [Carbon::now()->startOfWeek(), Carbon::now()->endOfWeek()])->get(); |
There was a problem hiding this comment.
Missing pagination on this responses
nicocadq
approved these changes
Apr 11, 2022
… into CU-20y76fa
rubenderigo
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Filtering by month and week.