Test query database compatibility #8
Conversation
Use 'SELECT 1', it's the more compatible. This works on most commonly used databases, like postgreSQL, mysql, mariadb, mssql (and probably others). But does _not_ work on, for example, oracle (and probably others). This is a, minimal impact, 'quick fix', better solution would be to go through Django's database backend 'is_usable' method. Fixes issue painless-software#3
|
Going through the Django database backend API would solve it for all databases, but a bit more work. |
|
Did you take a look at @dismine's suggestion, a list of compatible ping queries on StackOverflow? |
|
yeah, read that issue. Though instead of detecting the database type and using some hardcoded list, I would prefer just going through Django's own database abstraction. Each backend has a .is_usable method, which kinda does this (it would do a SELECT 1 on postgreSQL, on mysql a native connection ping method and probably something else on oracle). But that's not a one-liner fix :) Bit of extra work to, think you also need manually do the connect before that, requiring some extra exception handling, testing etc... so like I said, if I find some spare time, i'll do a follow up pull for that |
|
True. Also, Would you mind opening a separate issue on fixing things "the professional way" after I get this PR merged? That would help to track the issue properly. |
|
Thanks for opening the follow-up ticket! 🥇 |
Use 'SELECT 1', it's the more compatible. This works on most commonly
used databases, like postgreSQL, mysql, mariadb, mssql (and probably
others). But does not work on, for example, oracle (and probably
others).
This is a, minimal impact, 'quick fix', better solution would be to go
through Django's database backend 'is_usable' method.
Fixes issue #3