Provide support for professional Spid #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleDore
requested review from
balanza,
BurnedMarshal,
francescopersico and
gunzip
as code owners
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 66.26% 68.36% +2.09%
==========================================
Files 11 11
Lines 750 765 +15
Branches 117 124 +7
==========================================
+ Hits 497 523 +26
+ Misses 252 241 -11
Partials 1 1
Continue to review full report at Codecov.
|
balanza
reviewed
Apr 26, 2021
src/utils/middleware.ts
Outdated
Comment on lines
22
to
44
| export enum ProfessionalPurpose { | ||
| P = "P", | ||
| PX = "PX", | ||
| LP = "LP", | ||
| PG = "PG", | ||
| PF = "PF" | ||
| } | ||
|
|
||
| const ProfessionalSpidExtension = t.union([ | ||
| t.interface({ | ||
| professionalSpidEnabled: t.literal(false) | ||
| }), | ||
| t.interface({ | ||
| professionalSpidEnabled: t.literal(true), | ||
| purpose: t.union([ | ||
| t.literal(ProfessionalPurpose.P), | ||
| t.literal(ProfessionalPurpose.PX), | ||
| t.literal(ProfessionalPurpose.LP), | ||
| t.literal(ProfessionalPurpose.PG), | ||
| t.literal(ProfessionalPurpose.PF) | ||
| ]) | ||
| }) | ||
| ]); |
There was a problem hiding this comment.
If you need to consider every occurrence of ProfessionalPurpose in ProfessionalSpidExtension codec, you can link them by trasforming the first into a string literal union:
Suggested change
| export enum ProfessionalPurpose { | |
| P = "P", | |
| PX = "PX", | |
| LP = "LP", | |
| PG = "PG", | |
| PF = "PF" | |
| } | |
| const ProfessionalSpidExtension = t.union([ | |
| t.interface({ | |
| professionalSpidEnabled: t.literal(false) | |
| }), | |
| t.interface({ | |
| professionalSpidEnabled: t.literal(true), | |
| purpose: t.union([ | |
| t.literal(ProfessionalPurpose.P), | |
| t.literal(ProfessionalPurpose.PX), | |
| t.literal(ProfessionalPurpose.LP), | |
| t.literal(ProfessionalPurpose.PG), | |
| t.literal(ProfessionalPurpose.PF) | |
| ]) | |
| }) | |
| ]); | |
| type ProfessionalPurpose = t.TypeOf<typeof ProfessionalPurpose>; | |
| export const ProfessionalPurpose = t.keyof({ | |
| P: null, | |
| PX: null, | |
| LP: null, | |
| PG: null, | |
| PF: null, | |
| }); | |
| const ProfessionalSpidExtension = t.union([ | |
| t.interface({ | |
| professionalSpidEnabled: t.literal(false) | |
| }), | |
| t.interface({ | |
| professionalSpidEnabled: t.literal(true), | |
| purpose: ProfessionalPurpose | |
| }) | |
| ]); |
src/utils/__tests__/saml.test.ts
Outdated
| )(samlRequest) | ||
| .fold( | ||
| err => fail(err), | ||
| _ => expect(_).not.toContain("<spid:Purpose>P</spid:Purpose>") |
There was a problem hiding this comment.
I'd test on a less restrictive pattern, like <spid:Purpose, does it have sense?
BurnedMarshal
previously approved these changes
Apr 26, 2021
src/utils/saml.ts
Outdated
| @@ -68,6 +68,8 @@ export const SAML_NAMESPACE = { | |||
| XMLDSIG: "http://www.w3.org/2000/09/xmldsig#" | |||
| }; | |||
|
|
|||
| const SAML_EXTENSION = "https://spid.gov.it/saml‐extensions"; | |||
There was a problem hiding this comment.
Suggested change
| const SAML_EXTENSION = "https://spid.gov.it/saml‐extensions"; | |
| const SPID_SAML_EXTENSION = "https://spid.gov.it/saml‐extensions"; |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for professional SPID saml extension