feat: simplify example app's initial setup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spid-testenv2 1.1.0 autogenerates the key & certificate and it can also get a remote metadata at runtime, allowing us to avoid having to manually saving the metadata to a file. The testenv GETs the metadata from the example app on the first login attempt.
bfabio
requested review from
AleDore,
balanza,
BurnedMarshal,
francescopersico and
gunzip
as code owners
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 66.26% 67.06% +0.79%
==========================================
Files 11 11
Lines 750 759 +9
Branches 117 116 -1
==========================================
+ Hits 497 509 +12
+ Misses 252 249 -3
Partials 1 1
Continue to review full report at Codecov.
|
balanza
reviewed
Jan 18, 2021
| @@ -25,11 +25,12 @@ services: | |||
| - spid-testenv2 | |||
|
|
|||
| spid-testenv2: | |||
| image: italia/spid-testenv2:latest | |||
| image: italia/spid-testenv2:1.1.0 | |||
There was a problem hiding this comment.
Why stick to a specific version and not use the latest available?
There was a problem hiding this comment.
It's good practice to stick to a specific version for repeatability. A new major release could bring changes that break our assumptions on how the testenv behaves, such as an incompatible configuration format.
Co-authored-by: Daniele Manni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(upstreaming spid-express changes)
spid-testenv2 1.1.0 autogenerates the key & certificate and it
can also get a remote metadata at runtime, allowing us to avoid
having to manually save the metadata to a file.
The testenv GETs the metadata from the example app on the first
login attempt.