Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#HSL-7] Support spid-saml-check #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[#HSL-7] Support spid-saml-check #111

wants to merge 3 commits into from

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Jun 13, 2022

Introduce support for spid-saml-check as fake IDP for testing and development. spid-saml-check should be preferred to spid-testenv2 as the latter is now deprecated.

  • Add spid-saml-check IDP (here)
  • Refactor (here)

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jun 13, 2022 •
edited

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 55cb7d2

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

manuelcoppotelli
manuelcoppotelli approved these changes Jun 13, 2022
View reviewed changes
Copy link

@manuelcoppotelli manuelcoppotelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I'm concerned, I can only look at the integration flow with the SPID SAML Check component, not at the code

Technically the newly proposed entity_id xx_samlcheck works.

LGTM 👍

@manuelcoppotelli manuelcoppotelli mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcoppotelli manuelcoppotelli manuelcoppotelli approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@balanza @pagopa-github-bot @manuelcoppotelli