[#PE-168] - Here geolocation API integration #802
Conversation
AleDore
requested review from
balanza,
BurnedMarshal and
francescopersico
as code owners
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
AleDore
changed the title
| @@ -64,6 +64,7 @@ const aPagoPABasePath = "/pagopa/api/v1"; | |||
| const aMyPortalBasePath = "/myportal/api/v1"; | |||
| const aBPDBasePath = "/bpd/api/v1"; | |||
| const aCgnAPIBasePath = "/api/v1/cgn"; | |||
| const aGeoAPIBasePath = "/api/v1/geo"; | |||
There was a problem hiding this comment.
Should we be a little more specific here? Maybe /api/v1/cgn/geo or /api/v1/cgn-geo or /api/v1/here
There was a problem hiding this comment.
I'd rather maintain this naming since this set of APIS should be used by other App functionalities(i.e. services geolocation )
src/app.ts
Outdated
| @@ -402,6 +417,16 @@ export function newApp({ | |||
| authMiddlewares.bearerSession | |||
| ); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-use-before-define | |||
| registerGeoAPIRoutes( | |||
There was a problem hiding this comment.
Do we need to mount this sub-path after a condition on a feature flag?
There was a problem hiding this comment.
Yep, you're right.
| ); | ||
|
|
||
| app.get( | ||
| `${basePath}/geo/autocomplete`, |
There was a problem hiding this comment.
Isn't geo already included in basePath
There was a problem hiding this comment.
Nope, basePath includes only /api/v1. It's similar to CGN schema, see
Line 901 in 6431727
List of Changes
Integration with HERE Geolocation API.
We expose only 3 APIs through IO APP:
Motivation and Context
This feature is needed by Carta Giovani Nazionale Operators search through IO APP when a citizen deny to get tracked by GPS coordinates, so he needs to insert an address manually.
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: