[#158907283] Replace the old spid-testenv-identityserver with the new spid-testenv2 #287
Conversation
…he new spid-testenv2
Affected stories
Generated by 🚫 dangerJS |
| @@ -90,7 +90,7 @@ container.register({ | |||
| const SAML_CALLBACK_URL = | |||
| process.env.SAML_CALLBACK_URL || | |||
| "http://italia-backend/assertionConsumerService"; | |||
| const SAML_ISSUER = process.env.SAML_ISSUER || "http://italia-backend"; | |||
| const SAML_ISSUER = process.env.SAML_ISSUER || "http://italiabackend.it"; | |||
There was a problem hiding this comment.
because in the new testenv2 the issuer has to be a valid URL
There was a problem hiding this comment.
is there any reason on why this differs from the default saml issuer (https://spid.agid.gov.it/cd) ?
I mean, cant we just put https://spid.agid.gov.it/cd into the sp_metatadata.xml of the test spid IDP ?
lmorelli986
force-pushed
the
158907283-idp-auto-login
branch
from
32ea3d5
to
533fe91
Compare
src/container.ts
Outdated
| @@ -221,7 +224,7 @@ container.register({ | |||
| function createSimpleRedisClient(): redis.RedisClient { | |||
| const redisUrl = process.env.REDIS_URL || "redis://redis"; | |||
| log.info("Creating SIMPLE redis client", { url: redisUrl }); | |||
| return redis.createClient(); | |||
| return redis.createClient(redisUrl); | |||
There was a problem hiding this comment.
may you please open a new PR for this one ? (or a pivotal bug)
|
@lussoluca @lmorelli986 now that we have deployed the spid-testenv2 idp, can we start merging the integration without autologin? we need it for the Apple approval process, we can provide them with a username and a password |
|
In other words, this PR should add just one more entry to the spidStrategy.ts with the test IDP info. |
lussoluca
changed the title
The autologin user is configured as an environment variable. We can set that variable in the CI environment to perform tests.
At the moment we are blocked by italia/spid-testenv2#118