Skip to content

Commit

Permalink
fix: version on github is not aligned with version on store (#6463)
Browse files Browse the repository at this point in the history
## Short description
From latest runs of the new automated workflow, the tagged version and
the uploaded version are not aligned.
We upload the build 5 while tagging as 6.

This PR aims to fix this behaviour aligning the builds
  • Loading branch information
CrisTofani authored Nov 26, 2024
1 parent 4e12b91 commit c1373e2
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/release-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.prepare-canary-release.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-jdk-17
Expand Down Expand Up @@ -119,7 +120,7 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
release-ios:
needs: run-static-checks
needs: prepare-canary-release
environment: canary
runs-on: macos-13-xlarge
steps:
Expand All @@ -130,6 +131,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.prepare-canary-release.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-ruby
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/release-new-cycle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,15 @@ jobs:
bump-app-version:
needs: run-static-checks
runs-on: ubuntu-latest
environment: prod
outputs:
currentAppVersion: ${{ steps.github-release-creation.outputs.CURRENT_APP_VERSION }}
steps:
- id: checkout
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}
ssh-key: ${{ secrets.SSH_DEPLOY_KEY }}
- id: setup
uses: ./.github/actions/setup-composite
- id: bump-version
Expand All @@ -45,6 +48,7 @@ jobs:
- id: github-release-creation
run: |
APP_VERSION=$(node -p -e "require('./package.json').version")
echo "CURRENT_APP_VERSION=$APP_VERSION" >> $GITHUB_OUTPUT
gh release create $APP_VERSION --latest --generate-notes
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -57,6 +61,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.bump-app-version.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-jdk-17
Expand Down Expand Up @@ -132,6 +137,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.bump-app-version.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-ruby
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
needs: run-static-checks
runs-on: ubuntu-latest
environment: prod
outputs:
currentAppVersion: ${{ steps.github-release-creation.outputs.CURRENT_APP_VERSION }}
steps:
- id: checkout
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
Expand All @@ -29,6 +31,7 @@ jobs:
- id: github-release-creation
run: |
APP_VERSION=$(node -p -e "require('./package.json').version")
echo "CURRENT_APP_VERSION=$APP_VERSION" >> $GITHUB_OUTPUT
gh release create $APP_VERSION --latest --generate-notes
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -41,6 +44,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.bump-app-version.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-jdk-17
Expand Down Expand Up @@ -116,6 +120,7 @@ jobs:
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
with:
fetch-depth: 0
ref: ${{ needs.bump-app-version.outputs.currentAppVersion }}
- id: setup
uses: ./.github/actions/setup-composite
- id: setup-ruby
Expand Down

0 comments on commit c1373e2

Please sign in to comment.