Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove respond.js #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove respond.js #48

wants to merge 2 commits into from

Conversation

coaxial
Copy link
Contributor

@coaxial coaxial commented Jun 11, 2023

CSS media queries have been supported by every major browser for a while now, there is no need for the shim anymore.

coaxial added 2 commits June 11, 2023 10:45
Every major browser now supports CSS3 media queries, no need for the shim anymore.
@coaxial
Copy link
Contributor Author

coaxial commented Jul 2, 2023

Failed because:

   *  External link https://twitter.com/mattgraham failed: 302 Number of redirects hit maximum amount

HTML-Proofer found 1 failure!

I cannot re-rerun the action to see if it passes now.

@olifre
Copy link
Contributor

olifre commented Mar 10, 2024

I cannot re-rerun the action to see if it passes now.

You may want to rebase onto current master which will re-run the action automatically, it seems the temporary problem you encountered is gone for now.

olifre added a commit to olifre/olifre.github.io that referenced this pull request Mar 10, 2024
All recent browsers work fine without it.

See also: pages-themes/midnight#48
@olifre
Copy link
Contributor

olifre commented Mar 10, 2024

@coaxial I think one could go even further and also drop jQuery and the other two browser shims in the default layout, what do you think?
jQuery does not appear to be used anywhere else in the theme.

olifre added a commit to olifre/olifre.github.io that referenced this pull request Mar 10, 2024
All recent browsers work fine without it.

See also: pages-themes/midnight#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants