Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls_ciphers option to allow specifiying custom ciphers list #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pagekite/manual.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,15 @@
Default name to use for SSL, if SNI (Server Name Indication)
is missing from incoming HTTPS connections.

--tls_ciphers</b>=<a>cipher list</a> __
List of ciphers to use for front end server TLS sockets.
For example, Debian 11 and later may need <tt>DEFAULT@SECLEVEL=1</tt>
in order to allow TLSv1 connections from older embedded
backends. Make sure you know what you are doing when using this!

--tls_legacy __Allow legacy TLS for front end servers.
Make sure you know what you are doing when using this!

--tls_endpoint</b>=<a>name</a>:<a>/path/to/file</a> __
Terminate SSL/TLS for a name using key/cert from a file.

Expand All @@ -355,7 +364,7 @@
--savefile</b>=<a>/path/to/file</a> __
Saved settings will be written to this file.

--save __Save the current configuration to the savefile.
--save __Save the current configuration to the savefile.

--settings</b> __
Dump the current settings to STDOUT, formatted as a configuration
Expand Down
7 changes: 5 additions & 2 deletions pagekite/pk.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
'auththreads=', 'authdomain=', 'authfail_closed',
'motd=', 'register=', 'host=', 'noupgradeinfo', 'upgradeinfo=',
'ports=', 'protos=', 'portalias=', 'rawports=',
'tls_legacy', 'tls_default=', 'tls_endpoint=', 'selfsign',
'tls_legacy', 'tls_ciphers=', 'tls_default=', 'tls_endpoint=', 'selfsign',
'fe_certname=', 'fe_nocertcheck', 'ca_certs=',
'kitename=', 'kitesecret=',
'backend=', 'define_backend=', 'be_config=',
Expand Down Expand Up @@ -1080,6 +1080,7 @@ def ResetConfiguration(self):

self.tls_legacy = False
self.tls_default = None
self.tls_ciphers = None
self.tls_endpoints = {}
self.fe_certname = []
#
Expand Down Expand Up @@ -1555,6 +1556,7 @@ def addManualFrontends():
config.append('# tls_endpoint = DOMAIN:PEM_FILE')
config.extend([
p('tls_default = %s', self.tls_default, 'DOMAIN'),
p('tls_ciphers = %s', self.tls_ciphers, ''),
p('tls_legacy = %s', self.tls_legacy, False),
'',
])
Expand Down Expand Up @@ -2371,10 +2373,11 @@ def Configure(self, argv):
self.ui_paths[host] = hosti

elif opt == '--tls_default': self.tls_default = arg
elif opt == '--tls_ciphers': self.tls_ciphers = arg
elif opt == '--tls_legacy': self.tls_legacy = True
elif opt == '--tls_endpoint':
name, pemfile = arg.split(':', 1)
ctx = socks.MakeBestEffortSSLContext(legacy=self.tls_legacy)
ctx = socks.MakeBestEffortSSLContext(legacy=self.tls_legacy, ciphers=self.tls_ciphers)
ctx.use_privatekey_file(pemfile)
ctx.use_certificate_chain_file(pemfile)
self.tls_endpoints[name] = (pemfile, ctx)
Expand Down
1 change: 1 addition & 0 deletions pagekite_gtk.py